-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(flattenObject): change using constant date in test case #253
Conversation
@choi2021 is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There are a couple code formatting issues. This could be fixed by running Prettier on the whole file (yarn prettier --write src/object/flattenObject.spec.ts
), but that would create a larger diff because the file has mixed formatting currently.
PS: I approved this PR even though I’m not a maintainer. I’m not sure what this project's policy is for review by non-maintainers. Is it fine to approve, or better to just comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have made a PR regarding the take(compat) function, but it failed due to issues in the flattenObject test case.
The failure was caused by different date objects being used for comparison in the test cases.
To fix this, I have modified the test cases to use a consistent date object for comparisons, ensuring that the date objects being compared are identical.