Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(flattenObject): change using constant date in test case #253

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

choi2021
Copy link
Contributor

I have made a PR regarding the take(compat) function, but it failed due to issues in the flattenObject test case.

The failure was caused by different date objects being used for comparison in the test cases.

To fix this, I have modified the test cases to use a consistent date object for comparisons, ensuring that the date objects being compared are identical.

AS-IS
TO-BE
스크린샷 2024-07-15 오전 12 40 52

@choi2021 choi2021 requested a review from raon0211 as a code owner July 19, 2024 14:32
Copy link

vercel bot commented Jul 19, 2024

@choi2021 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (1d9d0da) to head (b9f31d8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         108      108           
  Lines         685      685           
  Branches      137      137           
=======================================
  Hits          682      682           
  Misses          3        3           

Copy link
Contributor

@fvsch fvsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

There are a couple code formatting issues. This could be fixed by running Prettier on the whole file (yarn prettier --write src/object/flattenObject.spec.ts), but that would create a larger diff because the file has mixed formatting currently.

PS: I approved this PR even though I’m not a maintainer. I’m not sure what this project's policy is for review by non-maintainers. Is it fine to approve, or better to just comment?

src/object/flattenObject.spec.ts Outdated Show resolved Hide resolved
src/object/flattenObject.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 0b71ce9 into toss:main Jul 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants