Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isUndefined): Add compatibility with lodash #266

Merged
merged 9 commits into from
Jul 21, 2024

Conversation

haejunejung
Copy link
Contributor

The result of benchmark as below :)
image

@haejunejung haejunejung requested a review from raon0211 as a code owner July 20, 2024 13:54
Copy link

vercel bot commented Jul 20, 2024

@haejunejung is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

raon0211
raon0211 previously approved these changes Jul 21, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 changed the title feat/isUndefined: Add compatability with lodash feat/isUndefined: Add compatibility with lodash Jul 21, 2024
@raon0211 raon0211 changed the title feat/isUndefined: Add compatibility with lodash feat(isUndefined): Add compatibility with lodash Jul 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2f76fd2) to head (9842052).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines          711       711           
  Branches       144       144           
=========================================
  Hits           711       711           

@raon0211 raon0211 merged commit d0812b8 into toss:main Jul 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants