chore: move browser build from umd dir to dist #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fvsch is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
raon0211
approved these changes
Jul 24, 2024
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284.
There were two issues reported in #284:
umd/browser.global.jsbundle was generated but not published in the package: fixed in chore: use rollup instead of tsup for a cleaner dist #255.umd/browser.global.jspath conveys the wrong information, because this bundle uses a simpler IIFE format declaring a global_variable, and not the UMD format.This PR moves this bundle to
dist/browser.global.js.Because the Rollup config takes this path from
package.json#publishConfig#browser, we only have to update it inpackage.json.