Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dedupe dependencies #607

Merged
merged 1 commit into from
Sep 28, 2024
Merged

chore: dedupe dependencies #607

merged 1 commit into from
Sep 28, 2024

Conversation

wojtekmaj
Copy link
Contributor

This is just the output of running yarn dedupe. Improves CI time, project's install time and disk space usage. My suggestion would be to make it a habit to dedupe after updating dependencies of any kind to avoid this problem in the future.

This is just the output of running `yarn dedupe`. Improves CI time, project's install time and disk space usage. My suggestion would be to make it a habit to dedupe after updating dependencies of any kind to avoid this problem in the future.
@wojtekmaj wojtekmaj requested a review from raon0211 as a code owner September 27, 2024 09:53
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:55am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (893ed16) to head (73e4e74).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         240      240           
  Lines        2048     2048           
  Branches      564      564           
=======================================
  Hits         2033     2033           
  Misses         14       14           
  Partials        1        1           

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right; maybe we might add this to a git hook or CI check.

@raon0211 raon0211 merged commit dacc523 into toss:main Sep 28, 2024
8 checks passed
@wojtekmaj wojtekmaj deleted the dedupe-deps branch September 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants