Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(random): correct JSDoc #81

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(random): correct JSDoc #81

merged 1 commit into from
Jun 21, 2024

Conversation

mass2527
Copy link
Contributor

I have revised the explanation to correct inaccuracies. I have also included additional details to improve developers' understanding.

@mass2527 mass2527 requested a review from raon0211 as a code owner June 20, 2024 13:21
Copy link

vercel bot commented Jun 20, 2024

@mass2527 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jun 20, 2024

CodSpeed Performance Report

Merging #81 will degrade performances by 85.5%

Comparing mass2527:fix/random (eaee3df) with main (92c9db0)

Summary

⚡ 9 improvements
❌ 4 regressions
✅ 73 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mass2527:fix/random Change
lodash/difference 211 µs 57.1 µs ×3.7
lodash/differenceWith 378.3 µs 223.3 µs +69.44%
es-toolkit/intersectionBy 57.3 µs 51.2 µs +12.02%
lodash/intersectionBy 437.4 µs 322.1 µs +35.79%
lodash/intersectionWith 246.4 µs 92.5 µs ×2.7
lodash/isNil 190.5 µs 35.7 µs ×5.3
lodash/pick 258.8 µs 86 µs ×3
lodash/shuffle 316.3 µs 195.6 µs +61.75%
lodash/union 76.3 µs 232 µs -67.11%
es-toolkit/uniqBy 11 ms 6.8 ms +61.25%
es-toolkit/xor 57.1 µs 393.8 µs -85.5%
lodash/xorBy 91.4 µs 378.6 µs -75.87%
lodash/zip 236.4 µs 387.3 µs -38.98%

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 1b3d9be into toss:main Jun 21, 2024
7 of 9 checks passed
@mass2527 mass2527 deleted the fix/random branch June 21, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants