-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compat): Add sortedIndex
, sortedIndexBy
to compat
#871
Open
1eeminhyeong
wants to merge
15
commits into
toss:main
Choose a base branch
from
1eeminhyeong:feat/sortedIndex-sortedIndexBy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(compat): Add sortedIndex
, sortedIndexBy
to compat
#871
1eeminhyeong
wants to merge
15
commits into
toss:main
from
1eeminhyeong:feat/sortedIndex-sortedIndexBy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 358 360 +2
Lines 3051 3104 +53
Branches 900 920 +20
=======================================
+ Hits 3050 3103 +53
Misses 1 1 |
@raon0211 hi! Is there anything I need to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#846
Implemented the
sortedIndex
,sortedIndexBy
functions in compat layer. I implemented them based on Lodash, but wrote using es-toolkit internal functions.benchmarks
coverage
These test cases were written with reference to the test cases of Lodash's sortedIndex, sortedIndexBy