Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compat): Add sortedIndex, sortedIndexBy to compat #871

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

1eeminhyeong
Copy link
Contributor

@1eeminhyeong 1eeminhyeong commented Dec 6, 2024

Description

#846
Implemented the sortedIndex, sortedIndexBy functions in compat layer. I implemented them based on Lodash, but wrote using es-toolkit internal functions.

benchmarks

스크린샷 2024-12-06 14 46 27
스크린샷 2024-12-06 15 02 49

coverage

These test cases were written with reference to the test cases of Lodash's sortedIndex, sortedIndexBy
스크린샷 2024-12-06 15 06 39
스크린샷 2024-12-06 15 07 13

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 6:10am

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (83787c8) to head (19d2e59).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         358      360    +2     
  Lines        3051     3104   +53     
  Branches      900      920   +20     
=======================================
+ Hits         3050     3103   +53     
  Misses          1        1           

@1eeminhyeong
Copy link
Contributor Author

@raon0211 hi! Is there anything I need to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants