Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groupBy): should handle keys like toString or valueOf #906

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

D-Sketon
Copy link
Contributor

No description provided.

@D-Sketon D-Sketon requested a review from raon0211 as a code owner December 15, 2024 13:10
Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 2:40pm

@D-Sketon D-Sketon changed the title fix: should handle keys like toString or valueOf fix(groupBy): should handle keys like toString or valueOf Dec 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (becaac5) to head (5ff3039).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         353      355    +2     
  Lines        3038     3044    +6     
  Branches      899      900    +1     
=======================================
+ Hits         3037     3043    +6     
  Misses          1        1           

src/array/groupBy.ts Outdated Show resolved Hide resolved
@raon0211 raon0211 merged commit 2215177 into toss:main Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants