fix(react): change defineSuspense function signature
#1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37f7a9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
People can be co-author:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dayongkr is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #1336 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 63 63
Lines 502 502
Branches 111 111
=======================================
Hits 385 385
Misses 111 111
Partials 6 6
|
manudeli
added a commit
that referenced
this pull request
Oct 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.18.4 ### Patch Changes - [#1336](#1336) [`91d8ae1`](91d8ae1) Thanks [@dayongkr](https://github.com/dayongkr)! - fix(react): change `defineSuspense` function signature ## @suspensive/react-query@2.18.4 ### Patch Changes - Updated dependencies \[[`91d8ae1`](91d8ae1)]: - @suspensive/react@2.18.4 - @suspensive/react-query-4@2.18.4 - @suspensive/react-query-5@2.18.4 ## @suspensive/react-query-4@2.18.4 ### Patch Changes - Updated dependencies \[[`91d8ae1`](91d8ae1)]: - @suspensive/react@2.18.4 ## @suspensive/react-query-5@2.18.4 ### Patch Changes - Updated dependencies \[[`91d8ae1`](91d8ae1)]: - @suspensive/react@2.18.4 ## @suspensive/jotai@2.18.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I made modifications because, when
componentPropsClientOnlyis set tofalse, it returnsSuspense, but the overloaded function signature indicated that it returnsSuspenseClientOnly.PR Checklist