Skip to content

Commit

Permalink
pkp#10292 fixing unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
touhidurabir committed Aug 20, 2024
1 parent 4845517 commit 1463f2d
Show file tree
Hide file tree
Showing 9 changed files with 91 additions and 544 deletions.
5 changes: 1 addition & 4 deletions classes/controlledVocab/ControlledVocab.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
<?php
/**
* @defgroup controlled_vocab Controlled Vocabulary
*/

/**
* @file classes/controlledVocab/ControlledVocab.php
Expand All @@ -12,7 +9,7 @@
*
* @class ControlledVocab
*
* @brief
* @brief ControlledVocab model class
*/

namespace PKP\controlledVocab;
Expand Down
274 changes: 0 additions & 274 deletions classes/controlledVocab/ControlledVocabDAO.php

This file was deleted.

21 changes: 21 additions & 0 deletions classes/controlledVocab/Repository.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
<?php

/**
* @file classes/controlledVocab/Repository.php
*
* Copyright (c) 2024 Simon Fraser University
* Copyright (c) 2024 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @class Repository
*
* @brief A repository to manage actions related to controlled vocab
*/

namespace PKP\controlledVocab;

use APP\facades\Repo;
Expand Down Expand Up @@ -38,11 +50,20 @@ public function getEntryDAO(): ControlledVocabEntryDAO
return DAORegistry::getDAO('ControlledVocabEntryDAO');
}

/**
* Return the extended Controlled Vocab Entry DAO.
* Can be subclassed to provide extended DAOs.
*
* Will be removed once the eloquent based settings table relations task completes.
*/
public function getEntryDaoBySymbolic(string $symbolic): ControlledVocabEntryDAO
{
return DAORegistry::getDAO(ucfirst($symbolic) . 'EntryDAO');
}

/**
* Get localized entry data
*/
public function getBySymbolic(
string $symbolic,
int $assocType,
Expand Down
Loading

0 comments on commit 1463f2d

Please sign in to comment.