-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tower: update tokio-util
to v0.7
#638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
`tokio-util` requires at least `tokio` v1.6.0 for `mpsc::Sender::reserve_owned`, but it only specifies a minimum version of v1.0.0. This is incorrect and should be considered an upstream bug, but updating our tokio dep fixes this, so that should at least unbreak `tower`'s build for now. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
LucioFranco
approved these changes
Feb 11, 2022
nightkr
added a commit
to nightkr/tower-http
that referenced
this pull request
Feb 14, 2022
This mirrors tower-rs/tower#638.
nightkr
added a commit
to nightkr/tower-http
that referenced
this pull request
Feb 14, 2022
According to tower-rs/tower#638, this is now required by tokio-util, but declared incorrectly.
davidpdrsn
pushed a commit
to tower-rs/tower-http
that referenced
this pull request
Feb 14, 2022
* tokio-util: 0.6.8 -> 0.7.0 This mirrors tower-rs/tower#638. * Bump tokio requirement to 1.6 According to tower-rs/tower#638, this is now required by tokio-util, but declared incorrectly.
hawkw
added a commit
that referenced
this pull request
Feb 16, 2022
# 0.4.12 (February 16, 2022) ### Fixed - **hedge**, **load**, **retry**: Fix use of `Instant` operations that can panic on platforms where `Instant` is not monotonic ([#633]) - Disable `attributes` feature on `tracing` dependency ([#623]) - Remove unused dependencies and dependency features with some feature combinations ([#603], [#602]) - **docs**: Fix a typo in the RustDoc for `Buffer` ([#622]) ### Changed - **hedge**: Updated `hdrhistogram` dependency to v7.0 ([#602]) - Updated `tokio-util` dependency to v0.7 ([#638]) [#633]: #633 [#623]: #623 [#603]: #603 [#602]: #602 [#622]: #622 [#638]: #638
hawkw
added a commit
that referenced
this pull request
Feb 16, 2022
* chore: prepare to release v0.4.12 # 0.4.12 (February 16, 2022) ### Fixed - **hedge**, **load**, **retry**: Fix use of `Instant` operations that can panic on platforms where `Instant` is not monotonic ([#633]) - Disable `attributes` feature on `tracing` dependency ([#623]) - Remove unused dependencies and dependency features with some feature combinations ([#603], [#602]) - **docs**: Fix a typo in the RustDoc for `Buffer` ([#622]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.49.0. - **hedge**: Updated `hdrhistogram` dependency to v7.0 ([#602]) - Updated `tokio-util` dependency to v0.7 ([#638]) [#633]: #633 [#623]: #623 [#603]: #603 [#602]: #602 [#622]: #622 [#638]: #638 * add msrv
dcormier
added a commit
to dcormier/tower
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
tokio-util
to v0.7.It also updates the minimum
tokio
dependency to v1.6.0.This is because
tokio-util
requires at leasttokio
v1.6.0 formpsc::Sender::reserve_owned
, but it only specifies a minimum versionof v1.0.0. This is incorrect and should be considered an upstream bug,
but updating our tokio dep fixes this, so that should at least unbreak
tower
's build for now.Signed-off-by: Eliza Weisman eliza@buoyant.io