Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unmatched deny ignore config #733

Merged
merged 2 commits into from
Jul 20, 2024
Merged

chore: Remove unmatched deny ignore config #733

merged 2 commits into from
Jul 20, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented May 11, 2023 •
edited
Loading

This cargo-deny config could be removed according to the warning.

warning[advisory-not-detected]: advisory was not encountered
  ┌─ /github/workspace/deny.toml:5:11
  │
5 │ ignore = ["RUSTSEC-2020-0159"]
  │           ^^^^^^^^^^^^^^^^^^^ no crate matched advisory criteria

advisories ok, bans ok, licenses ok, sources ok

ref: https://github.com/tower-rs/tower/actions/runs/4829234227/jobs/8604020802#step:4:13

GlenDC
GlenDC approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobz tobz added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-ci Topic: continuous integration labels Jul 20, 2024
@tobz tobz merged commit f286933 into tower-rs:master Jul 20, 2024
14 checks passed
@tobz tobz added the S-awaiting-release Status: approved/merged but awaiting a release. label Jul 20, 2024
@tottoto tottoto deleted the update-deny-config branch July 21, 2024 00:49
@tobz
Copy link
Member

tobz commented Aug 13, 2024

This has been released as part of tower@v0.5.0.

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: approved/merged but awaiting a release. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GlenDC GlenDC GlenDC approved these changes

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-ci Topic: continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tottoto @tobz @GlenDC