-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misspelled keyword argument poll_interval
for method acquire
#119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test to validate this?
I think we can reimplement this by using decorators without changing the signature of the method. |
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
I think the current implementation is fine, no need for decorators. |
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Thanks for your contribution. |
I don't know where it's coming from (maybe virtualenv?) but I'm getting a lot of warnings:
|
@ofek Can you try to run |
Fix misspelled keyword argument
poll_interval
for methodacquire
. Fixes #62.I tried my best to add the backward compatibility layer in this PR to not break existing codebases.