Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelled keyword argument poll_interval for method acquire #119

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Fix misspelled keyword argument poll_interval for method acquire #119

merged 5 commits into from
Nov 16, 2021

Conversation

XuehaiPan
Copy link
Contributor

Fix misspelled keyword argument poll_interval for method acquire. Fixes #62.

I tried my best to add the backward compatibility layer in this PR to not break existing codebases.

src/filelock/_api.py Outdated Show resolved Hide resolved
src/filelock/_api.py Outdated Show resolved Hide resolved
src/filelock/_api.py Outdated Show resolved Hide resolved
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test to validate this?

@XuehaiPan
Copy link
Contributor Author

I think we can reimplement this by using decorators without changing the signature of the method.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat
Copy link
Member

I think we can reimplement this by using decorators without changing the signature of the method.

I think the current implementation is fine, no need for decorators.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit a6c8fab into tox-dev:main Nov 16, 2021
@gaborbernat
Copy link
Member

Thanks for your contribution.

@XuehaiPan XuehaiPan deleted the fix-typo branch November 16, 2021 11:03
@ofek
Copy link

ofek commented Nov 20, 2021

I don't know where it's coming from (maybe virtualenv?) but I'm getting a lot of warnings:

tests/cli/build/test_build.py: 10 warnings
tests/cli/env/test_create.py: 45 warnings
tests/cli/env/test_prune.py: 6 warnings
tests/cli/env/test_remove.py: 12 warnings
tests/cli/publish/test_publish.py: 42 warnings
tests/cli/run/test_run.py: 18 warnings
tests/dep/test_core.py: 24 warnings
tests/venv/test_core.py: 21 warnings
  /home/runner/.local/share/hatch/env/virtual/hatch-kmtIAcBK/hatch/lib/python3.9/site-packages/filelock/_api.py:151: DeprecationWarning: use poll_interval instead of poll_intervall
    warnings.warn(msg, DeprecationWarning)

@XuehaiPan
Copy link
Contributor Author

XuehaiPan commented Nov 20, 2021

I don't know where it's coming from (maybe virtualenv?) but I'm getting a lot of warnings:

@ofek Can you try to run python -W error xxx.py or pytest ... -W error to see what module uses the old argument poll_intervall?

@ofek
Copy link

ofek commented Nov 20, 2021

@ofek
Copy link

ofek commented Nov 20, 2021

pypa/virtualenv#2237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poll_intervall is a misspelling
3 participants