Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails if the package contains '-' #31

Closed
hkad98 opened this issue Mar 6, 2024 · 3 comments
Closed

Installation fails if the package contains '-' #31

hkad98 opened this issue Mar 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@hkad98
Copy link

hkad98 commented Mar 6, 2024

Issue

The installation fails when the package contains a '-' character in the name. The following line of code causes it:

https://github.com/tox-dev/tox-uv/blob/main/src/tox_uv/_installer.py#L88

The error message I got:

Caused by: Package metadata name gooddata-sdk does not match given name gooddata

Environment

Provide at least:

  • OS: 14.2 (23C64)
Output of pip list of the host Python, where tox is installed
Package             Version
------------------- -------
cachetools          5.3.3
chardet             5.2.0
colorama            0.4.6
distlib             0.3.8
filelock            3.13.1
gooddata-api-client 1.14.0
gooddata-dbt        1.14.0
gooddata-pandas     1.14.0
gooddata-sdk        1.14.0
packaging           23.2
pip                 24.0
platformdirs        4.2.0
pluggy              1.4.0
pyproject-api       1.6.1
setuptools          69.1.1
tox                 4.14.0
tox-uv              1.5.0
uv                  0.1.15
virtualenv          20.25.1
@hkad98 hkad98 added the bug Something isn't working label Mar 6, 2024
@gaborbernat
Copy link
Member

PR welcome 😊

@gaborbernat
Copy link
Member

Can you please provide the full output of your error? Now I think your build backend is generating an invalid wheel file name, so is a bug there - see https://peps.python.org/pep-0427/#escaping-and-unicode

@hkad98
Copy link
Author

hkad98 commented Mar 7, 2024

I tried the new version – 1.5.1, and it works now. Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants