Fix fail for package with '-' in name #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When package contained '-' tox-uv failed to install it. The name was split and the first part was taken which caused that the rest of the name was missing.
gaborbernat
requested changes
Mar 6, 2024
| @@ -0,0 +1,130 @@ | |||
| """ | |||
There was a problem hiding this comment.
Don't copy, just make name configurable with an env-var.
There was a problem hiding this comment.
That will not work. The name contains '-', but pkg_name does not. See logic, plugin, and other variables that use pkg_name instead of name.
There was a problem hiding this comment.
It will. I've done it for you in #33, and also demonstrating I believe that the bug is not in our tool but your build backend violating PEP-427.
Add tests for package with '-' in the name.
hkad98
force-pushed
the
fix-name-with-dash
branch
from
c0210be
to
9b611fc
Compare
|
Ah, nice. Thanks for taking care, you two :) |
gaborbernat
force-pushed
the
fix-name-with-dash
branch
2 times, most recently
from
793ef9d
to
9b611fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When package contained '-' tox-uv failed to install it. The name was split and the first part was taken which caused that the rest of the name was missing.
Closes: #31