-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - tox 4 #1400
WIP - tox 4 #1400
Conversation
bdcfa3f
to
6a1cb8a
Compare
lmk when you want me to take a look at this (@-me), going to mute until then o7 |
@asottile probably not in the next two weeks 👍 no worries |
caf86f7
to
043db4c
Compare
"""Report the status of a tox environment""" | ||
|
||
def __init__(self, result_log, name, content): | ||
self.reportlog = result_log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaborbernat
JFI: this is unused (also now already (27d7a6a - feel free to pick it, but I've thought it could be an API break etc))
I have some time and more importantly mind space now and would like to work my way into this, would this make sense at the moment @gaborbernat? |
It's definitely possible; though mind you the state of this branch is a very early alpha, with not all platforms supported yet 👍 Maybe first look at the code and tell me your thoughts 👍 I do plan to pick this up eventually but first would like to roll out the virtualenv rewrite. |
o.k. I am especially interested atm on how this can help us integrating docker better and how we can improve reporting. I am not 100% sure yet if a rewrite is a really good idea or a more incremental approach (which my gut feeling rather would tend to), but I'll definitely have a look to get a feeling for the direction you are heading. |
As someone who maintains a POC version of the docker thing my experience is that a major rewrite is necessariy to make it sustainable. We want to end up with something that's also fast, not just correct; and does not require patching in 5 different locations. In the current state of things none of these three are easily achievable. 😢 The rewrite will make this possible though I feel like. |
Will close for now, 👍 |
No description provided.