Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests when HOSTNAME is set, but empty string #1618

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix tests when HOSTNAME is set, but empty string #1618

merged 1 commit into from
Jul 15, 2020

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 14, 2020

See #1616 (comment)

This is a fixup of cfe66fd.

  • wrote descriptive pull request text
  • added/updated test(s)
  • added news fragment in changelog folder
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@hroncok hroncok mentioned this pull request Jul 14, 2020
Merged
6 tasks
asottile
asottile reviewed Jul 14, 2020
View reviewed changes
tests/unit/test_result.py Outdated Show resolved Hide resolved
@hroncok
Fix tests when HOSTNAME is set, but empty string
e54ca1d 
Use a pytest provided fixture instead of implementing our own.

See tox-dev#1616 (comment)

This is a fixup of cfe66fd.
asottile
asottile approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 7a65627 into tox-dev:master Jul 15, 2020
@hroncok hroncok deleted the hostname_env2 branch July 16, 2020 11:15
@hroncok
Copy link
Contributor Author

hroncok commented Jul 16, 2020

Thanks for the suggestion and merge!

@gaborbernat
Copy link
Member

This now is done under 3.17.1, thanks for the contribution!

ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
@hroncok @ssbarnea
Fix tests when HOSTNAME is set, but empty string (tox-dev#1618)
68845ee 
Use a pytest provided fixture instead of implementing our own.

See tox-dev#1616 (comment)

This is a fixup of cfe66fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile asottile approved these changes

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hroncok @gaborbernat @asottile