-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SecRandomCopyBytes
#43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05nelsonm
commented
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
🤔 |
05nelsonm
force-pushed
the
issue/39-secrandomcopybytes
branch
4 times, most recently
from
October 2, 2023 14:55
bd5d3c5
to
95943af
Compare
05nelsonm
force-pushed
the
issue/39-secrandomcopybytes
branch
from
October 2, 2023 15:32
95943af
to
8611b1c
Compare
05nelsonm
commented
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
05nelsonm
force-pushed
the
issue/39-secrandomcopybytes
branch
from
October 2, 2023 18:50
0b0121a
to
77eb39c
Compare
05nelsonm
commented
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
05nelsonm
force-pushed
the
issue/39-secrandomcopybytes
branch
3 times, most recently
from
October 3, 2023 01:28
c1058f6
to
fe3250e
Compare
05nelsonm
force-pushed
the
issue/39-secrandomcopybytes
branch
from
October 3, 2023 03:16
fe3250e
to
c6b917e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix to #39 , which will remain open until things go live upstream and can be pulled into this codebase.
The fix allows enabling of
tvOS
andwatchOS
targets.It modifies the
SQLite3MultipleCiphers
amalgamations to useSecRandomCopyBytes
for darwin targets, in line with the fix expressed HERE.