Merge pull request #320 from petterip/main

fix: only validate required input fields
tphakala · Nov 16, 2024 · f7b378a · f7b378a
2 parents ce17437 + 081ea7c
commit f7b378a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/views/settings/settingsBase.html b/views/settings/settingsBase.html
@@ -83,13 +83,14 @@
         }, 5000);
     },
     isFormValid(form) {
-        const visibleFieldsValid = Array.from(form.elements)
-        .filter(element => element.offsetParent !== null)
-        .every(element => element.checkValidity());
+        const inputSelector = 'input[type=\'password\'][required], input[type=\'text\'][required]';
+        const requiredFields = form.querySelectorAll(inputSelector);
+        const visibleFieldsValid = Array.from(requiredFields)
+            .filter(element => element.offsetParent !== null)
+            .every(element => element.checkValidity());
 
-        const inputSelector = 'input[type=\'password\'], input[type=\'text\']';
         if(!visibleFieldsValid) {
-            form.querySelectorAll(inputSelector).forEach(input => {
+            requiredFields.forEach(input => {
                 if (input.offsetParent === null) return;
 
                 input.checkValidity();