Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic github action for building docker image #39

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

isZumpo
Copy link
Contributor

@isZumpo isZumpo commented Mar 2, 2024

Implements a basic github action job that will for every commit to the main branch, build and push a docker
image to the latest tag. The latest tag will get overwritten after each commit.

In the future it might be better to instead decide on some better tagging strategy.

Speeds up the copy process since the git history is
not of interest while building the image.
The workflow job will for every new commit
to the main branch, build and push a docker
image to the latest tag. The latest tag
will get overwritten each commmit.
@tphakala tphakala merged commit ea817bc into tphakala:main Mar 3, 2024
@isZumpo
Copy link
Contributor Author

isZumpo commented Mar 3, 2024

@tphakala there appears to be some sort of permission error now when the action runs:

denied: installation not allowed to Create organization package

I did not experience this when running it in my fork. Perhaps there is a setting that must be adjusted for the repository?

@tphakala
Copy link
Owner

tphakala commented Mar 3, 2024

It was a privilege issue, now fixed.

@isZumpo
Copy link
Contributor Author

isZumpo commented Mar 3, 2024

It was a privilege issue, now fixed.

Great! Now it seems to be running as expected. Could you also make the docker packages public? Then it should be accessible for everyone.

@tphakala
Copy link
Owner

tphakala commented Mar 3, 2024

done!

@isZumpo isZumpo deleted the docker-build-action branch March 3, 2024 15:14
@tphakala
Copy link
Owner

tphakala commented Mar 3, 2024

I updated workflow to support multiplatform builds, at the moment it builds linux/amd64 and linux/arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants