Fix process leak #70
Merged
Fix process leak #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 12:29
For each connection, a Handler process is started, monitored by DynamicSupervisor. When connection ends, Handler process should stop.
jeanparpaillon
force-pushed
the
fix-process-leak
branch
from
7e57cab
to
31f8aa0
Compare
tpitale
approved these changes
Dec 14, 2020
tpitale
reviewed
Dec 14, 2020
added 2 commits
December 14, 2020 10:56
Use Process.monitor instead of custom message from Connection to Handler to stop the latter
tpitale
approved these changes
Dec 14, 2020
|
Merge whenever you're ready @jeanparpaillon, or I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make handler transient
For each connection, a Handler process is started, monitored by DynamicSupervisor.
When connection ends, Handler process should stop.