-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowDataset/windows function #1553
WindowDataset/windows function #1553
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
=======================================
Coverage 86.39% 86.40%
=======================================
Files 688 689 +1
Lines 78675 78704 +29
=======================================
+ Hits 67974 68002 +28
- Misses 10701 10702 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antimora I could add an individual WindowDataset
section here if required but I thought for now the crate documentation would be sufficient as it is quite clear what is going on and the api isn't too complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not extremely familiar with time-series tasks but thank you for the pointers in the linked issue! I can understand the use cases better.
Implementation LGTM! Clean, concise and easy to understand with the added tests 🙂
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
WindowDataset
/windows
#1551Changes
WindowDataset
and awindows
implementation inDataset
.Testing
cd crates/burn-dataset && cargo test window