Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowDataset/windows function #1553

Merged
merged 32 commits into from
Apr 17, 2024

Conversation

NicoZweifel
Copy link
Contributor

@NicoZweifel NicoZweifel commented Mar 28, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Changes

  • Adds WindowDataset and a windows implementation in Dataset.

Testing

  • cd crates/burn-dataset && cargo test window

@NicoZweifel NicoZweifel changed the title TimeSeries/WindowedDataset example TimeSeries/WindowedDataset Mar 28, 2024
@antimora antimora added the feature The feature request label Mar 28, 2024
@NicoZweifel NicoZweifel changed the title TimeSeries/WindowedDataset TimeSeries/DatasetWindows Apr 2, 2024
@NicoZweifel NicoZweifel changed the title TimeSeries/DatasetWindows DatasetWindows Apr 2, 2024
@NicoZweifel NicoZweifel mentioned this pull request Apr 2, 2024
2 tasks
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (2f88548) to head (c6bba94).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   86.39%   86.40%           
=======================================
  Files         688      689    +1     
  Lines       78675    78704   +29     
=======================================
+ Hits        67974    68002   +28     
- Misses      10701    10702    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicoZweifel NicoZweifel changed the title DatasetWindows WindowDataset/windows function Apr 10, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antimora I could add an individual WindowDataset section here if required but I thought for now the crate documentation would be sufficient as it is quite clear what is going on and the api isn't too complex.

@NicoZweifel NicoZweifel marked this pull request as ready for review April 10, 2024 14:55
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not extremely familiar with time-series tasks but thank you for the pointers in the linked issue! I can understand the use cases better.

Implementation LGTM! Clean, concise and easy to understand with the added tests 🙂

@nathanielsimard nathanielsimard merged commit 5a3f345 into tracel-ai:main Apr 17, 2024
14 checks passed
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants