Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign ONNX op import support #1663

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Add sign ONNX op import support #1663

merged 2 commits into from
Apr 22, 2024

Conversation

wufniks
Copy link
Contributor

@wufniks wufniks commented Apr 19, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

I couldn't find one.

Changes

Added sign ONNX op import support

Testing

Added unit tests for codegen and expected outputs

@wufniks wufniks changed the title Sign op Added sign ONNX op import support Apr 19, 2024
@wufniks wufniks changed the title Added sign ONNX op import support Add sign ONNX op import support Apr 19, 2024
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this op!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (9fbcbed) to head (6ee6ef7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files         694      694           
  Lines       80675    80716   +41     
=======================================
+ Hits        69719    69760   +41     
  Misses      10956    10956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 2a7b296 into tracel-ai:main Apr 22, 2024
14 checks passed
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
* Add sign ONNX op support

* Update SUPPORTED-ONNX-OPS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants