Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit backend: Fix PRNG bug during autotune #1791

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented May 20, 2024

During the element types refactor of #1693 some types in PRNG that really needed to be Float were accidentally replaced with the input's element type. This could cause a type mismatch in the PRNG kernel, which could happen during autotune of int/bool tensors, which call uniform distribution PRNG.

Fix #1790

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (76fe0ed) to head (67a434f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   86.39%   86.40%           
=======================================
  Files         737      737           
  Lines       85883    85891    +8     
=======================================
+ Hits        74202    74210    +8     
  Misses      11681    11681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 6137d42 into main May 22, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/jit/prng_float branch May 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with element types in JIT when using all(), related to PRNG
2 participants