Remainder operator doc #1836
Merged
Remainder operator doc #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
==========================================
- Coverage 86.47% 86.44% -0.03%
==========================================
Files 698 759 +61
Lines 82874 87791 +4917
==========================================
+ Hits 71667 75894 +4227
- Misses 11207 11897 +690 ☔ View full report in Codecov by Sentry. |
LilDojd
pushed a commit
to LilDojd/burn
that referenced
this pull request
Jun 5, 2024
* Adds remainder ops implementation for Tensor. * Adds test for % operator. * Add remainder and % operator entry in tensor.md --------- Co-authored-by: Jonas Kantic <jk.mail@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Related PR: 1726
Changes
Problem: The tensor.remainder_scalar() method has been implemented in a previous PR. However, its not possible to use the % operator, e.g., tensor % 2.0.
Changes: Added ops::Rem trait implementation for Tensor.
Testing
Added a test for Tensor that makes use of the % operator.