-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/cube/mutability #1934
Refactor/cube/mutability #1934
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 85.09% 84.56% -0.54%
==========================================
Files 791 793 +2
Lines 93319 93859 +540
==========================================
- Hits 79412 79370 -42
- Misses 13907 14489 +582 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (shallow review, but i'll merge it in my stuff to see if it works well)
Now arrays and tensors are passed by reference to functions, since they don't implement copy anymore.