-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precision option for tensor display #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few left out comments to be removed. I'll approve in advance 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 694 694
Lines 89005 89070 +65
=======================================
+ Hits 76806 76865 +59
- Misses 12199 12205 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh that's pretty useful! Thanks for adding this 😄
Thanks for reviewing my precision PR. The left comments were intentional. Do you think I should still remove them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only comment left to document restrictions seems fine to me :) thanks for the changes
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
Testing
New unit test for formatter precision option. The global precision settings were tested manually because the change affects other test threads.