fix: Allow annotation templates for services that need them #1181

[brow86]

What does this PR do?

This fixes #1181 by doing the following:

• Adds a templateAnnotations value to default values file and keeps it as true to keep existing behavior
• Updates deployment template to leverage the new boolean
• Add true/false test cases

Motivation

This should help avoid issues with Hashicorp Vault and agent injection and any other service which uses templates as a part of its annotations.

More

• Yes, I updated the tests accordingly
• Yes, I ran make test and all the tests passed

[mloiseleur]

I understand your needs. I'm not sure of the correct way to fix it and it seems a really specific needs.

The tpl has been introduced last year with #972 from @ivankatliarchuk .

Don't you have a way to "print" template code with tpl ?

[brow86]

@mloiseleur - Point taken on this being a specific use case but I can see this potentially being a problem with any other service that does template interpolation with annotations which-- moving forward-- may be a lot more than just this one case. In other words, I'd be shocked if this doesn't break something else moving forward. As for solving it, the PR introduces a boolean to flip it off and defaults it to the default behavior of running tpl, does that work?

The only other thing I'll mention is that we use this on a lot of our helm charts and traefik is the first chart I've run into that templates the values out-of-the-box. Chart templates on other popular repos like grafana and the nginx don't template out-of-the-box so, while I agree it is helpful and should be kept in, many other charts don't currently do this.

[brow86]

@mloiseleur - Wanted to poke this again. Is the purposed PR not viable? Is there another suggested approach?

[mloiseleur]

@brow86 It's explained in the README:

AFAIK, without any PR, one can set its template using a Configmap with Vault and agent injection.