-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error with explicit latest tag #384
Conversation
…helm-chart into fix-latesttag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested that change locally, no issues occurred.
Sure, one should never use latest tag. At least when you're not pulling from a registry that expunges older images, or some rare exceptions when you need some missing feature that's not in an official release, ... doesn't really apply here. |
Like to throw an error if you are trying to run it with latest? I would like that :) |
allright, that should do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected preventing a user to deploy the latest tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
following-up on #360
latest tag handling.
Fixes #321