fix: ingressclass name should be customizable #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kupnu4x: Thanks for this PR Would you please detail why you add a new value instead of using Or, to ask this question in a different way, do you think we should use this new value also on |
z0rc
suggested changes
Jun 19, 2023
Co-authored-by: Rémi BUISSON <remi-buisson@orange.fr>
Co-authored-by: Rémi BUISSON <remi-buisson@orange.fr>
Co-authored-by: Rémi BUISSON <remi-buisson@orange.fr>
mloiseleur
force-pushed
the
fix-ingressclass
branch
from
0c5ac66
to
4070408
Compare
mloiseleur
changed the title
mloiseleur
approved these changes
Jul 25, 2023
mloiseleur
added
status/3-needs-merge
and removed
contributor/waiting-for-corrections
labels
terrych0u
pushed a commit
to terrych0u/traefik2-helm-chart
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com> Co-authored-by: Rémi BUISSON <remi-buisson@orange.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue #855
More
make testand all the tests passed