Clarify how setting a frontend priority works #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
area/documentation
status/2-needs-review
kind/bug/fix
ldez
suggested changes
Mar 8, 2018
docs/basics.md
Outdated
| @@ -234,7 +234,7 @@ The following rules are both `Matchers` and `Modifiers`, so the `Matcher` portio | |||
| #### Priorities | |||
|
|
|||
| By default, routes will be sorted (in descending order) using rules length (to avoid path overlap): | |||
| `PathPrefix:/12345` will be matched before `PathPrefix:/1234` that will be matched before `PathPrefix:/1`. | |||
| `PathPrefix:/12;Host:foo.com` (length == 27) will be matched before `PathPrefixStrip:/123` (length == 20) will be matched before `PathPrefix:/12,/3` (length == 17). | |||
There was a problem hiding this comment.
could you replace numbers by letters.
ex: PathPrefix:/12 -> PathPrefix:/foo
jbdoumenjou
force-pushed
the
hotfix/doc-priorities
branch
from
44f5b50
to
cf1cc91
Compare
juliens
requested changes
Mar 8, 2018
docs/basics.md
Outdated
| @@ -254,7 +254,7 @@ You can customize priority by frontend. The priority value is added to the rule | |||
| rule = "PathPrefix:/toto" | |||
| ``` | |||
|
|
|||
| Here, `frontend1` will be matched before `frontend2` (`(3 + 10 == 13) > (4 + 5 == 9)`). | |||
| Here, `frontend1` will be matched before `frontend2` (`(14 + 10 == 24) > (16 + 5 == 21)`). | |||
There was a problem hiding this comment.
I think that in reality, if you specify a priority, you don't use the length and use directly the value. Can you verify this ?
There was a problem hiding this comment.
In Traefik 1.5, a custom priority does ignore the length-based factor according to my tests not too long ago.
There was a problem hiding this comment.
Yes, I made a mistake, the priority override the rule length according to https://github.com/containous/traefik/blob/master/server/server.go#L1192
jbdoumenjou
force-pushed
the
hotfix/doc-priorities
branch
from
6dfbf11
to
64a8178
Compare
traefiker
force-pushed
the
hotfix/doc-priorities
branch
from
64a8178
to
ee70874
Compare
jbdoumenjou
force-pushed
the
hotfix/doc-priorities
branch
from
ee70874
to
18071ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the documentation to clarify how setting a frontend priority works
Motivation
Some misunderstanding on the frontend priority mechanism
Related to #2722
More