Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.2.0 #499

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Release v4.2.0 #499

merged 1 commit into from
Aug 10, 2023

Conversation

richardboehme
Copy link
Contributor

No description provided.

@@ -1,3 +1,3 @@
module Cell
VERSION = "4.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous versioning here seems mess 😄 I'm wondering if anyone using 4.5.0 would be able to get updates from >= 4.2.0 & < 4.5.0.

Should we release incremental minor version instead ? cc @apotonick

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not released 4.5.0, yet, have we not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not from rubygems but in case someone is using github repo in Gemfile directly ? I hope there shouldn't be any problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but let's go with 4.2.0 and face the consequences 💥 😂

@yogeshjain999
Copy link
Member

@richardboehme when are we releasing this ? 🥺

@richardboehme
Copy link
Contributor Author

@richardboehme when are we releasing this ? 🥺

I think we wanted to make sure that the new version would be 100% compatible with cells-rails. While working on this we noticed that we do not test all compatible template engines in cells-rails. I wanted to build tests for this but I could not make time for it yet :(

@yogeshjain999
Copy link
Member

While working on this we noticed that we do not test all compatible template engines in cells-rails.

I wonder why we need to test all templates engines in cells-rails tests. Shouldn't their own tests should suffice ?

@apotonick
Copy link
Member

I wonder why we need to test all templates engines in cells-rails tests. Shouldn't their own tests should suffice ?

In cells-rails we test Rails helpers support, you don't want that mixed up in the clean template gems. That's why cells-rails is the "benchmark" for helper compatibility.

@apotonick apotonick merged commit b5ceeaa into trailblazer:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants