Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operators.ORD for BitVecs of size > 8 #1512

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Fix operators.ORD for BitVecs of size > 8 #1512

merged 2 commits into from
Aug 22, 2019

Commits on Aug 22, 2019

  1. Fix operators.ORD for BitVecs of size > 8 

    TLDR: `ORD(s)` should return something that has 8 bits instead of 7, which it incorrectly did for BitVecs with size>8.

Note that the `ORD` still does not support `BitVec`s with size<8, but I am not sure if we need that support for now. To be clear, such situation ends up as an assertion failure that is being done in `BitVecExtract`, so when assertions are gone (for optimized launches) we might want to extend `ORD` to support it.
    @disconnect3d
    disconnect3d authored Aug 22, 2019
    Configuration menu
    Copy the full SHA
    54ea691 View commit details
    Browse the repository at this point in the history

  2. Add proper ORD fix testcase

    @disconnect3d
    disconnect3d committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    9153e02 View commit details
    Browse the repository at this point in the history