Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cran preparation for APCalign 0.0.1 release #85

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Cran preparation for APCalign 0.0.1 release #85

merged 10 commits into from
Aug 3, 2023

Conversation

fontikar
Copy link
Collaborator

@fontikar fontikar commented Aug 2, 2023

Address #84

  • Updated DESCRIPTION
  • Added and updated NEWS.md
  • cran_comments.md
  • Updates to Rbuilldignore

@fontikar fontikar requested a review from wcornwell August 2, 2023 06:45
@wcornwell
Copy link
Contributor

do we want to resolve #70 as part of this?

@fontikar
Copy link
Collaborator Author

fontikar commented Aug 3, 2023

do we want to resolve #70 as part of this?

Can do.
What do you think you of these roles? Following these guidelines
@dfalster auth, cre
@ehwenk auth, ctb
@wcornwell auth, ctb
@fontikar auth, ctb (though I am not sure how much I can contribute to writing about plant taxonomy so happy to be ctb only)
Carl B ctb for contentID? Would he like to be on paper as auth?
Unsure about Herve's role (my guess auth)
Waiting on Anna Monroe and Anne Fuchs (both probably auth, ctb)
Unsure about Fabrice, and Ruby and Sophie

@dfalster
Copy link
Member

dfalster commented Aug 3, 2023

Hi @fontikar , good idea. Regarding the uncertainty

  • Carl B as ctb for contentID: yes, for now, we'll invite his for paper and we can update role later as needed
  • Herve : not yet, might contribute to paper and we can add then
  • Anna Monroe and Anne Fuchs (both probably auth, ctb): leave off for now, can add later
  • Fabrice: no, he contributed to another package which I used as template for this, but we've swapped that out for contentID
  • Ruby and Sophie: only very small commits so don't list yet. Would be good to involve them in paper with use cases and testing, we can add them then if they contribute there .

@wcornwell
Copy link
Contributor

wcornwell commented Aug 3, 2023

COPYRIGHT HOLDER: Your name here

COPYRIGHT HOLDER: Your name here

Copy link
Contributor

@wcornwell wcornwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fontikar fontikar merged commit 812c1f7 into master Aug 3, 2023
6 checks passed
@fontikar fontikar deleted the cran branch August 3, 2023 04:00
@ctb
Copy link

ctb commented Aug 3, 2023

(note I'm @ctb ;)

@fontikar
Copy link
Collaborator Author

fontikar commented Aug 3, 2023

Oh dear so sorry for the tag! Thanks for dropping by 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants