chore: Update

tests/test_middleware.py

@@ -4,6 +4,32 @@
 from prometheus_fastapi_instrumentator import Instrumentator, metrics
 
 
+def test_info_body_default():
+    """
+    Tests that `info.response.body` is empty even if response body is not empty.
+    This is the expected default that can be changed with `body_handlers`.
+    """
+
+    app = FastAPI()
+    client = TestClient(app)
+
+    @app.get("/", response_class=responses.PlainTextResponse)
+    def root():
+        return "123456789"
+
+    instrumentation_executed = False
+
+    def instrumentation(info: metrics.Info) -> None:
+        nonlocal instrumentation_executed
+        instrumentation_executed = True
+        assert len(info.response.body) == 0
+
+    Instrumentator().instrument(app).add(instrumentation)
+
+    client.get("/")
+    assert instrumentation_executed
+
+
 def test_info_body_empty():
     """
     Tests that `info.response.body` is empty if actual response is also empty.
@@ -13,7 +39,7 @@ def test_info_body_empty():
     client = TestClient(app)
 
     @app.get("/")
-    def read_root():
+    def root():
         return responses.Response(status_code=status.HTTP_200_OK)
 
     instrumentation_executed = False
@@ -23,7 +49,7 @@ def instrumentation(info: metrics.Info) -> None:
         instrumentation_executed = True
         assert len(info.response.body) == 0
 
-    Instrumentator().instrument(app).add(instrumentation)
+    Instrumentator(body_handlers=[r".*"]).instrument(app).add(instrumentation)
 
     client.get("/")
     assert instrumentation_executed
@@ -38,7 +64,7 @@ def test_info_body_stream_small():
     client = TestClient(app)
 
     @app.get("/")
-    def read_root():
+    def root():
         return responses.StreamingResponse((str(num) + "xxx" for num in range(5)))
 
     instrumentation_executed = False
@@ -66,23 +92,21 @@ def test_info_body_stream_large():
     client = TestClient(app)
 
     @app.get("/")
-    def read_root():
-        return responses.StreamingResponse(
-            (str(num) + "x" * 10000000 for num in range(5))
-        )
+    def root():
+        return responses.StreamingResponse(("x" * 1_000_000 for _ in range(5)))
 
     instrumentation_executed = False
 
     def instrumentation(info: metrics.Info) -> None:
         nonlocal instrumentation_executed
         instrumentation_executed = True
-        assert len(info.response.body) >= 50000000
+        assert len(info.response.body) == 5_000_000
 
     Instrumentator(body_handlers=[r".*"]).instrument(app).add(instrumentation)
 
     response = client.get("/")
     assert instrumentation_executed
-    assert len(response.content) >= 50000000
+    assert len(response.content) == 5_000_000
 
 
 def test_info_body_bulk_small():
@@ -94,7 +118,7 @@ def test_info_body_bulk_small():
     client = TestClient(app)
 
     @app.get("/", response_class=responses.PlainTextResponse)
-    def read_root():
+    def root():
         return "123456789"
 
     instrumentation_executed = False
@@ -123,19 +147,19 @@ def test_info_body_bulk_large():
     client = TestClient(app)
 
     @app.get("/", response_class=responses.PlainTextResponse)
-    def read_root():
-        return "x" * 50_000_000
+    def root():
+        return "x" * 5_000_000
 
     instrumentation_executed = False
 
     def instrumentation(info: metrics.Info) -> None:
         print(info.response.body)
         nonlocal instrumentation_executed
         instrumentation_executed = True
-        assert len(info.response.body) == 50_000_000
+        assert len(info.response.body) == 5_000_000
 
     Instrumentator(body_handlers=[r".*"]).instrument(app).add(instrumentation)
 
     response = client.get("/")
     assert instrumentation_executed
-    assert len(response.content) == 50_000_000
+    assert len(response.content) == 5_000_000