fix: Use value if HTTP status is enum #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 90.81% 90.84% +0.03%
==========================================
Files 5 5
Lines 283 284 +1
==========================================
+ Hits 257 258 +1
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blag
reviewed
Feb 7, 2023
blag
approved these changes
Feb 9, 2023
Co-authored-by: blag <blag@users.noreply.github.com>
trallnag
force-pushed
the
bugfix/http-status-code-enumeration
branch
from
ba68107
to
d821585
Compare
trallnag
changed the title
trallnag
force-pushed
the
bugfix/http-status-code-enumeration
branch
from
e76ef67
to
7ebe9b7
Compare
|
Thanks. Sorry for missing Hacktober |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #190 the instrumentator has a bug when using the
http.HTTPStatusenumeration for a status code response. If fixed this bug and added some tests to verify.I would be very thankful if you would add the
HACKTOBERFEST-ACCEPTEDto this pull request.