Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve typing #231

Merged
merged 2 commits into from
Mar 11, 2023
Merged

fix: Improve typing #231

merged 2 commits into from
Mar 11, 2023

Conversation

tomtom103
Copy link
Contributor

What does this do?

Improve typing support.

Why do we need it?

Some methods are not typed / do not follow the typing from prometheus_client.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #231 (5c64a06) into master (5f533f4) will increase coverage by 0.30%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   94.98%   95.29%   +0.30%     
==========================================
  Files           5        5              
  Lines         339      340       +1     
==========================================
+ Hits          322      324       +2     
+ Misses         17       16       -1     
Impacted Files Coverage Δ
...rc/prometheus_fastapi_instrumentator/middleware.py 96.62% <92.85%> (+1.12%) ⬆️
...ometheus_fastapi_instrumentator/instrumentation.py 97.10% <100.00%> (ø)
src/prometheus_fastapi_instrumentator/metrics.py 93.70% <100.00%> (ø)
src/prometheus_fastapi_instrumentator/routing.py 94.44% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trallnag trallnag merged commit 568bfbe into trallnag:master Mar 11, 2023
@trallnag
Copy link
Owner

Thanks

@trallnag
Copy link
Owner

@tomtom103 tomtom103 deleted the fix-improve-typing branch March 11, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants