fix: Fix info.response.body empty with normal responses #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 95.29% 95.58% +0.29%
==========================================
Files 5 5
Lines 340 340
==========================================
+ Hits 324 325 +1
+ Misses 16 15 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
trallnag
added a commit
that referenced
this pull request
Mar 19, 2023
- chore: Fix - chore: Add tests - chore: Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixes problem where in instrumentation functions
info.response.bodyis empty if response is just a response (not being streamed).Also adds tests that check this behavior.
Linked issues
Fixes #236