-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penumbra 5.0.0: Safari/Firefox Support #171
Conversation
…am & TransformStream
…-io/penumbra into eligrey/temp-safari-workaround
7a91e44
to
68d246f
Compare
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 66.94% 66.46% -0.49%
==========================================
Files 34 34
Lines 829 829
Branches 139 139
==========================================
- Hits 555 551 -4
- Misses 194 195 +1
- Partials 80 83 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Penumbra 4.18.x brings support to safari, however we dynamically import encrypt/decrypt functions into the the main thread for safari use. This created files 0.js and 1.js and 2.js that needed to be copied into the build. Since webpack commonly uses these file names, this often created a file naming conflict with the application that is importing penumbra.
The changes here modify the namespace of the compiled penumbra files so that all files end in
.penumbra.js
. This is a breaking change to the previous webpack configuration.New Style
webpack.js
index.html
<script src="/main.penumbra.js"></script>
Old Style
webpack.js
index.html
<script src="/penumbra.js"></script>