Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-21478 Add Oconus Rate area to prime v3 getMoveTaskOrder api #14112

Open
wants to merge 6 commits into
base: integrationTesting
Choose a base branch
from

Conversation

MInthavongsay
Copy link
Contributor

@MInthavongsay MInthavongsay commented Nov 5, 2024

B-21478

Summary

This PR introduces changes to the Prime V3 getMoveTaskOrder API to return Oconus (ie.. Alaska postal codes) Rate Area for all shipments.

It introduces two new OPTIONAL fields: originRateArea, destinationRateArea:

Screenshot 2024-11-05 at 7 34 34 AM
Screenshot 2024-11-05 at 7 34 17 AM

select * from re_rate_areas where id = '<ID>';

RateArea display is derived off Pickup and Destination postal codes. originRateArea/destinationRateArea will only be present if code is an OCONUS(Alaska) zip code and its location is determined based on shipment type. All non-PPM shipment will display rateArea on the root level of shipment while PPM will display on the PPMShipment level.

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Login as customer and create and submit a move containing all shipment types. For each shipment use all permutations for pickup and destination addresses with alaska and other continental states. NOTE -- at this time the system is not capable of accepting Alaska postal codes for PPM shipments. Need to follow up with Danny M on how to test with current restriction. For non-PPMs, you can use Alaska postal codes but you can't use AK for state. For now, just select any state but make sure to use an Alaska postal code. select distinct state, postal_code from addresses where state = 'AK';
  2. Login as service counselor and click for move.
  3. Login as TOO and find move. Select all shipments and click
  4. Login Prime Sim. Open web developer and go to network tab. Click on move and go to details view. In network tab view, select getMoveTaskOrder request. It will typically be at the bottom of the network request stack. View response json and confirm originRateArea/destinationRateArea if present/not present based on test cases.
  5. Verify placement of rateArea information. Root level of shipment for non-PPM shipments and PPMShipment level for PPMs.
    Screenshot 2024-11-05 at 8 30 29 AM
    Screenshot 2024-11-05 at 7 18 19 AM
  6. Goto http://primelocal:3000/swagger-ui/prime_v3.html#/moveTaskOrder/getMoveTaskOrder. Copy moveID from Prime Sim UI and execute. Verify rateArea info. Must match what is seen in step 5.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Nov 5, 2024
@MInthavongsay MInthavongsay self-assigned this Nov 5, 2024
@r-mettler
Copy link
Contributor

image Able to see the rate areas with shipment to AK.

Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and tests pass.

Screenshot 2024-11-15 at 7 45 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

3 participants