Various code optimizations. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhenii0
reviewed
Mar 15, 2021
| // We need to give a non-null random key, so triggers will be evenly spread around partitions. | ||
| // With <null> key, the kafka client will start doing some kind of batch partitioning. | ||
|
|
||
| String key = String.valueOf((char) ThreadLocalRandom.current().nextInt(0xFFFF)); |
There was a problem hiding this comment.
UuidUtils.generatePrefixCombUuid().toString() was too expensive?
There was a problem hiding this comment.
Relatively to the new solution yes, but it did not matter too much on grand scale. Just a minor tweak.
yevhenii0
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Optimizations.
Changes
Various code optimizations.
Checklist
change:standard,change:impactful,change:emergency)