Remove testcontainers, use docker-compose plugin #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhenii0
changed the title
yevhenii0
changed the title
onukristo
approved these changes
Oct 13, 2020
integration-tests/build.gradle
Outdated
| testImplementation libraries.awaitility | ||
| } | ||
|
|
||
| // junit4 deps are not used, exclude those | ||
| configurations.testImplementation.exclude group: 'junit', module: 'junit' |
There was a problem hiding this comment.
In some projects, I have used central registry for unwanted libs. For example in Webapp and in Payout: https://github.com/transferwise/payout-service/blob/master/build.common.gradle#L61
The benefit of that approach is, that it is in one place and prevents any kind of accidental transitive dependency coming in for any reason.
There was a problem hiding this comment.
Thanks, moved to build.common.gradle
| @@ -52,3 +52,10 @@ services: | |||
| command: "mysqld --ssl=0 | |||
| --character-set-server=utf8mb4 | |||
| --collation-server=utf8mb4_unicode_ci --transaction-isolation=READ-COMMITTED --innodb_autoinc_lock_mode=2" | |||
| postgres: | |||
| image: postgres:10.4 | |||
There was a problem hiding this comment.
Lets up to 12, we have only couple of database not upgraded to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we have same job done by both testcontainers and docker-compose plugin, keep a single approach for integration tests. Also, since we dropped testcontainers, junit4 dep can be excluded as well, which means 1
@Testannotation in the classpath 😉Additionally removing xRequestId support which pollutes build logs with deprecation warnings.