-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert from appDir to pages #1
Open
transitive-bullshit
wants to merge
46
commits into
main
Choose a base branch
from
feature/revert-to-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
transitive-bullshit
force-pushed
the
feature/revert-to-pages
branch
from
November 22, 2022 05:48
0118012
to
2c8ec0b
Compare
transitive-bullshit
force-pushed
the
feature/revert-to-pages
branch
from
November 22, 2022 05:48
2c8ec0b
to
3a064d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience developing this app, Next.js 13
appDir
is not yet stable enough to use in production.I encountered dozens of different errors during my time experimenting with server components, but the following three have been showstoppers for me:
Therefore, this PR reverts the app to use the non-
appDir
version of Next.js 13. Lighthouse performance is actually slightly better with the non-appDir version, and I was able to easily re-enablenext-themes
for toggling dark mode.