Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRI crash on neighbor calculation for geohash: a. #4

Open
jemc opened this issue Jul 21, 2017 · 1 comment
Open

MRI crash on neighbor calculation for geohash: a. #4

jemc opened this issue Jul 21, 2017 · 1 comment

Comments

@jemc
Copy link

jemc commented Jul 21, 2017

The current c_geohash gem

$ ruby --version
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]
$ gem list --local c_geohash

*** LOCAL GEMS ***

c_geohash (1.1.2)

encounters a SIGABRT when calculating the neighbors of a:

ruby -rgeohash -e 'GeoHash.new("a").neighbors'
Vince-Smith added a commit to Vince-Smith/geohash that referenced this issue May 8, 2019
@Vince-Smith
Prevent crashing when computing neighbors
6f483ce 
* Raise error on invalid geocode characters.
* Prevent recursing past end of string.

fixes transitland#4
@Vince-Smith Vince-Smith mentioned this issue May 8, 2019
Closed
@Vince-Smith
Copy link

"a" is not a valid geocode character.

I have opened up #5 to address this by raising an error on invalid characters.

There was an additional bug where computing neighbors of geohashes on some borders was causing the same crash. This is addressed in the above PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent crashing when computing neighbors Vince-Smith/geohash
2 participants
@jemc @Vince-Smith