Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update aws-s3.md wrt S3 public access settings
In my case, following the Uppy S3 documentation related to CORS by the letter still resulted in 403 responses with `AccessDenied` from my bucket's HTTP endpoint when my browser tried to upload a file. It seems like S3 introduced an additional layer of security which generally overrides any public access settings in other places to protect inexperienced S3 users from accidentially making content in their S3 buckets public - at least this is my interpretation. Therefore I extended the docs to inform Uppy users about the additional measures they potentially need to take.
- Loading branch information
b03613d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation change is incorrect. There is no second layer of security, and turning off the "block" will make "it work" because you're literally saying to remove access control. This has been in the docs for three years, and apparently people are following this advice, but it's not necessary (and incorrect).
Further
git blame
shows that the author had not set up CORS correctly in the first place: de9effd.For future reference, please don't write instructions that are unverified, based on a hunch, as if they're facts.