companion: use decodeURI only when value is set

transloadit · Jun 20, 2019 · cabff1b · cabff1b
1 parent 3d167cd
commit cabff1b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/@uppy/companion/src/uppy.js b/packages/@uppy/companion/src/uppy.js
@@ -229,11 +229,12 @@ const getOptionsMiddleware = (options) => {
    * @param {function} next
    */
   const middleware = (req, res, next) => {
+    const versionFromQuery = req.query.uppyVersions ? decodeURIComponent(req.query.uppyVersions) : null
     req.uppy = {
       options,
       s3Client,
       authToken: req.header('uppy-auth-token') || req.query.uppyAuthToken,
-      clientVersion: req.header('uppy-versions') || decodeURIComponent(req.query.uppyVersions) || '1.0.0',
+      clientVersion: req.header('uppy-versions') || versionFromQuery || '1.0.0',
       buildURL: getURLBuilder(options)
     }
     next()