Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Pass newFile with all the info to onBeforeFileAdded #1594

Closed
wants to merge 2 commits into from

Conversation

arturi
Copy link
Contributor

@arturi arturi commented May 24, 2019

  • Pass newFile with all the info to onBeforeFileAdded — this way file.type will be set and other properties like meta and isRemote will be available to onBeforeFileAdded callback.
  • Run _checkRestrictions and _checkMinNumberOfFiles before onBeforeFileAdded and onBeforeUpload callbacks — not sure about this one, @goto-bus-stop. Should restrictions be run before or after callbacks? 🤔 The issue was raised in Restrictions should be enforced before calling onBeforeUpload #1545.

…Added and onBeforeUpload callbacks

Addresses #1545, but I’m not sure this is the right move. Is it better to check restrictions before or after the callbacks?
@arturi arturi requested a review from goto-bus-stop May 24, 2019 17:45
@arturi arturi changed the title Pass newFile with all the info to onBeforeFileAdded core: Pass newFile with all the info to onBeforeFileAdded May 24, 2019
@arturi arturi closed this in #1726 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant