Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion: add colors to logs #1648

Merged
merged 3 commits into from
Jun 18, 2019
Merged

companion: add colors to logs #1648

merged 3 commits into from
Jun 18, 2019

Conversation

ifedapoolarewaju
Copy link
Contributor

No description provided.

Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 did you do an npm install && npm run bootstrap after adding the new dependency? seems to me like lerna should dedupe it and put it in the root package-lock.json instead of companion's, but mabe not...

@arturi
Copy link
Contributor

arturi commented Jun 12, 2019

In my console nothing gets colored with this PR 🤔

@ifedapoolarewaju
Copy link
Contributor Author

ifedapoolarewaju commented Jun 12, 2019 via email

@ifedapoolarewaju
Copy link
Contributor Author

did you do an npm install && npm run bootstrap after adding the new dependency?

@goto-bus-stop ah didn't realize I needed to do that

@arturi arturi self-requested a review June 17, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants