-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
companion: add colors to logs #1648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 did you do an npm install && npm run bootstrap
after adding the new dependency? seems to me like lerna should dedupe it and put it in the root package-lock.json instead of companion's, but mabe not...
In my console nothing gets colored with this PR 🤔 |
It’s more obvious when you get a warning or an error logged
… On 12 Jun 2019, at 7:19 PM, Artur Paikin ***@***.***> wrote:
In my console nothing gets colored with this PR 🤔
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@goto-bus-stop ah didn't realize I needed to do that |
743f805
to
9d44696
Compare
No description provided.