Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

companion-client: rename serverHeaders to companionHeaders #1861

Merged
merged 1 commit into from
Oct 9, 2019
Merged

companion-client: rename serverHeaders to companionHeaders #1861

merged 1 commit into from
Oct 9, 2019

Conversation

goto-bus-stop
Copy link
Contributor

For consistency with companionUrl etc.

serverHeaders still works but is no longer documented. We can remove it in V2.

@goto-bus-stop goto-bus-stop mentioned this pull request Oct 7, 2019
Merged
@arturi arturi self-requested a review October 9, 2019 12:27
arturi
arturi approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@arturi arturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Works locally too.

Companion itself doesn’t care about the change, since it receives those headers with no ties to serverHeaders or companionHeaders key, right? Just making sure :)

@goto-bus-stop
Copy link
Contributor Author

yeap correct

@goto-bus-stop goto-bus-stop merged commit d6d4b05 into master Oct 9, 2019
@goto-bus-stop goto-bus-stop deleted the chore/companion-headers branch October 9, 2019 12:34
@snyk-bot snyk-bot mentioned this pull request Jul 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturi arturi arturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @arturi