List virtualization and lazy thumbnails #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
commented
Mar 30, 2020
goto-bus-stop
changed the title
|
Great-great work, Renée! 👍 🥇 Tested in Chrome, Firefox and Safari on Mac, Chrome is the slowest for some reason. Thumbnail generation, even delayed, seems to be the bottleneck — text files render much snappier. |
|
@lakesare you reviewed this last time and found important bugs, could you take a look again, please? :) |
arturi
approved these changes
Apr 13, 2020
|
@arturi, sure, I can review it on Tuesday if it can wait 👌 |
This comment has been minimized.
This comment has been minimized.
|
The interesting artefact is that when we delete the file, focus jumps to the first item in the last virtualized row. Not a huge issue, but doesn't look 100% good on desktops when we click with a mouse.
|
lakesare
reviewed
Apr 14, 2020
lakesare
reviewed
Apr 14, 2020
lakesare
reviewed
Apr 14, 2020
lakesare
reviewed
Apr 14, 2020
|
thanks for the feedback @lakesare! gonna look into the mobile view issue now, that's not very good 😬 |
This comment has been minimized.
This comment has been minimized.
The `focusout` event could be fired before `componentDidUpdate` is called, and then we'd lose focus anyway, so it basically didn't work. I wanted to avoid `componentWillUpdate` but it seems like the most reliable option right now. I guess it's only discouraged in React proper anyway, and fine in Preact!
goto-bus-stop
force-pushed
the
virtualization-and-lazy-thumbnails
branch
from
2b7bd91 to
d3c1179
Compare
|
🎉🚀🥇💯🎉🚀🥇💯🎉🚀🥇💯 |
|
🎉 🎉 🎉 🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the Dashboard to only render those files that are actually in view, and to only generate thumbnails for files that are in view.
When a FileItem mounts, a thumbnail is requested. There is a case where you might scroll to one place A, and then scroll to another place B before all the thumbnails were ready. Then, you might have to wait until Uppy has generated thumbnails for the files visible at A before any of the files at B start getting thumbnails. So, if a FileItem unmounts before a thumbnail is generated, we cancel the thumbnail request, which reduces that delay.
Issues: