Add opts.disabled for the Dashboard #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So they can be grayscaled via css
|
Nice! I slightly modified this:
¹ Note: I had to add classes to |
arturi
commented
Feb 24, 2021
| @@ -502,6 +504,12 @@ module.exports = class Dashboard extends Plugin { | |||
| } | |||
| } | |||
|
|
|||
| disableAllFocusableElements = (disable) => { | |||
| const focusableNodes = toArray(this.el.querySelectorAll(FOCUSABLE_ELEMENTS)) | |||
| focusableNodes.forEach(node => node.setAttribute('tabindex', disable ? '-1' : '0')) | |||
There was a problem hiding this comment.
@goto-bus-stop what do you think of this? I’ve checked and we mostly have tabindex=0 on FOCUSABLE_ELEMENTS, nothing else is used, so not worth storing the previous value before changing it to -1?
P.S. TIL “The maximum value for tabindex is 32767”.
This was referenced Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nqst what do you think?
Closes #1530